Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue10 Further UI Improvements #11

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Issue10 Further UI Improvements #11

wants to merge 8 commits into from

Conversation

meejain
Copy link
Collaborator

@meejain meejain commented Apr 27, 2024

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #10

Test URLs:

@meejain meejain requested a review from asthabh23 April 27, 2024 09:41
@meejain meejain self-assigned this Apr 27, 2024
Copy link

aem-code-sync bot commented Apr 27, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Apr 29, 2024

Page Scores Audits
/qsr/Q1-2024/edsv1 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS

Copy link
Member

@asthabh23 asthabh23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a horizontal scroll for lesser viewports majorly because of the image under section "Powerful narrative".
A possible fix could be to stack it below the content of that section (for lesser viewport)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Further UI Improvements
2 participants