Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message keyLength error #2

Open
LinuxPlusPlus opened this issue Nov 19, 2013 · 3 comments
Open

Message keyLength error #2

LinuxPlusPlus opened this issue Nov 19, 2013 · 3 comments

Comments

@LinuxPlusPlus
Copy link

There is a problem in Message::Message(Packet *packet, long int offset) when keyLength return -1; I try to fix that in my fork. Can you think over that?

@DavidTompkins
Copy link
Member

Is this the same as issue #1 ? Fixed in v 0.4.0?

@LinuxPlusPlus
Copy link
Author

No, Fixed in v0.4.0 on issue #1 just avoid reading -1 buffer. But when produced message has no key, keyLength is -1, I found that Message::getWireFormatSize result missing 1, becasue "size += sizeof(int) + this->keyLength;"(Message.cpp:157), actully keyLenght should be 0, not -1.

@LinuxPlusPlus
Copy link
Author

Oh, I think it twice, maybe you're right, it's the same as issue #1 . But Fixed in V0.4.0 not really fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants