Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional but empty arrays are considered an error #15

Closed
otto-ifak opened this issue Apr 9, 2024 · 6 comments
Closed

Optional but empty arrays are considered an error #15

otto-ifak opened this issue Apr 9, 2024 · 6 comments

Comments

@otto-ifak
Copy link
Collaborator

Currently, arrays which are optional (i.e. not required) are considered as an error when present but empty.
Eg:

{
  "conceptDescriptions": []
}

is currently rejected.

We need to clarify if this is compliant to the spec.

@otto-ifak
Copy link
Collaborator Author

See also #13 (comment)

@otto-ifak
Copy link
Collaborator Author

I would argue for removing minItems: 1 from https://github.com/admin-shell-io/aas-test-engines/blob/main/aas_test_engines/data/file/3.0.yml then (currently 28 instances)

@sebbader-sap
Copy link

The desired behaviour, as agreed in the AAS Specification working group, is that no empty conceptDescriptions array is present. Therefore, the minItems: 1 clauses are correct.

@sebbader-sap
Copy link

We need to clarify if this is compliant to the spec.

It is :-)

@otto-ifak
Copy link
Collaborator Author

Great, thanks @sebbader-sap for clarifying this!

@juileetikekar
Copy link
Collaborator

Related issue in the specifications, admin-shell-io/aas-specs#418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants