-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NPM module #67
Comments
I see this is on npm now, but when I add it to my package.json and run |
I don't think that npm module is for this project. The one I found on npm pointed to https://github.com/pgorzelany/xapi-wrapper/blob/master/package.json , which looks like a stock trading script. |
I've converted it over to a Node module, I still need to develop so comprehensive tests before merging it back into this repo. You can install it using It will also attach to the window if not imported using Node JS, instead including as |
Have there been any updates to a completed node module with tests? |
Is this really not available as a server-side node module? (edited) |
It looks like there are two npm packages with a quick serach: @oliverfoster how will you be using the package? In node, or a front end app like Angular/React/Vue? |
I want to use the nice statement api in node, server side, as an installable node module. I made xapiwrapper-node from xapiwrapper by creating a shim for the browser apis which the module mostly unnecessarily depends on. (^ I did this so that I could easily merge changes from the original repo, isolate the browser-only dependencies and as a quick test to see if it would work - it does, beautifully) I say it mostly unnecessarily depends on the browser APIs because the xapi-launch module uses MutationObserver to listen for a settings DOM node - which seems to be a major part of its primary use-case. From my work it seems possible to change the library to UMD and provide a cross environment implementation of XMLHttpRequest, a url parser and a globals object, etc - putting xapi-launch aside for the moment - this would mean that both browser and server-side developers could use this module to communicate with the LRS. |
If we can get agreement that this work is worth doing and if i can confirm that a PR would be accepted, I'll happily submit one. |
It's definitely worth doing |
Any chance of keeping the npm module up to date? https://www.npmjs.com/package/xapiwrapper |
Is this repo up on NPM? I'm not able to find it, it would be nice to npm install
The text was updated successfully, but these errors were encountered: