You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current implementation of ADL.launch uses getQueryVariable [1], which assumes that it will always be able to get the launch parameters from window.location. This is not true if window is an iframe, for example for an embedded H5P on a Moodle page.
It would be great if this use case could be supported somehow, perhaps by trying to get launch parameters from the parent iframe (if it exists) as a fallback, or by allowing to override the launch parameters by passing them explicitly.
The current implementation of
ADL.launch
usesgetQueryVariable
[1], which assumes that it will always be able to get the launch parameters fromwindow.location
. This is not true ifwindow
is an iframe, for example for an embedded H5P on a Moodle page.It would be great if this use case could be supported somehow, perhaps by trying to get launch parameters from the parent iframe (if it exists) as a fallback, or by allowing to override the launch parameters by passing them explicitly.
[1]
xAPIWrapper/src/xapi-launch.js
Line 3 in d6637d3
The text was updated successfully, but these errors were encountered: