Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Make getQueryVariable iframe aware or at least allow to pass launch parameters to launch explicitly #165

Open
ralokt opened this issue Mar 26, 2020 · 0 comments

Comments

@ralokt
Copy link

ralokt commented Mar 26, 2020

The current implementation of ADL.launch uses getQueryVariable [1], which assumes that it will always be able to get the launch parameters from window.location. This is not true if window is an iframe, for example for an embedded H5P on a Moodle page.

It would be great if this use case could be supported somehow, perhaps by trying to get launch parameters from the parent iframe (if it exists) as a fallback, or by allowing to override the launch parameters by passing them explicitly.

[1]

function getQueryVariable(variable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant