Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard directory does not work when using custom_nodes folder #54

Open
ryanwalder opened this issue Jun 25, 2024 · 0 comments · May be fixed by #56
Open

Wildcard directory does not work when using custom_nodes folder #54

ryanwalder opened this issue Jun 25, 2024 · 0 comments · May be fixed by #56

Comments

@ryanwalder
Copy link

ryanwalder commented Jun 25, 2024

Reproduce:

  1. Create extra_model_paths.yaml file in comfyui base directory (EG: /home/foo/ComfyUI)
  2. Configure custom custom_nodes directory in other_ui config in /home/foo/ComfyUI/extra_model_paths.yaml
    •  other_ui:
         base_path: /path/to/custom/directory
         custom_nodes: custom_nodes
  3. Clone this repo into the new custom_nodes directory
    • git clone https://github.com/adieyal/comfyui-dynamicprompts /path/to/custom/directory/custom_nodes/comfyui-dynamicprompts
  4. (Optional) Create some wildcards in /path/to/custom/directory/custom_nodes/comfyui-dynamicprompts/wildcards
  5. Run ComfyUI
  6. Try and use Dynamic Prompts
    • Directory created: /home/foo/ComfyUIc/ustom_nodes/comfyui-dynamicprompts/wildcards
      • Obviously no wildcards in this freshly created directory

The plugin should be reading the wildcards from /path/to/custom/directory/custom_nodes/comfyui-dynamicprompts/wildcards

This then introduces errors during loading because comfyui tries to load the plugin from base_dir/custom_nodes

Traceback (most recent call last):
  File "/home/ryan/git/comfyui/nodes.py", line 1906, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 879, in exec_module
  File "<frozen importlib._bootstrap_external>", line 1016, in get_code
  File "<frozen importlib._bootstrap_external>", line 1073, in get_data
FileNotFoundError: [Errno 2] No such file or directory: '/home/ryan/git/comfyui/custom_nodes/comfyui-dynamicprompts/__init__.py'
@ryanwalder ryanwalder linked a pull request Jun 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant