Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Road to native ES modules #2341

Open
1 of 11 tasks
mrtnzlml opened this issue May 5, 2021 · 2 comments
Open
1 of 11 tasks

Road to native ES modules #2341

mrtnzlml opened this issue May 5, 2021 · 2 comments

Comments

@mrtnzlml
Copy link
Member

mrtnzlml commented May 5, 2021 •
edited
Loading

There are some dependencies that started pushing native ES modules in a very invasive way, see:

We need to replace or upgrade these. However, we are not ready for it. So here is the plan to make it happen:

Goals:

  • be able to use ESM packages within Universe
  • be able to export package to NPM with both CJS and ESM exports (in a non-invasive way if possible)

Eventually, we can drop support for CJS altogether.

Resources:

Known problems:
mrtnzlml added a commit that referenced this issue May 5, 2021
@mrtnzlml
Dependabot: disable pure ESM packages
363ff51 
See: #2341
@mrtnzlml mrtnzlml mentioned this issue May 5, 2021
Merged
@michalsanger
Copy link
Contributor

So what is our goal? I see two different ones:

  1. To be able to use ESM packages within Universe
  2. Export libs from Universe to NPM as to support both ESM and CJS

mrtnzlml added a commit that referenced this issue May 5, 2021
@mrtnzlml
Dependabot: disable pure ESM packages
44e672d 
See: #2341
@mrtnzlml
Copy link
Member Author

mrtnzlml commented May 5, 2021

@michalsanger I see both of the points to be goals of this issue. I updated the issue description to be more clear about the goals. Thanks!

michalsanger added a commit that referenced this issue May 10, 2021
@michalsanger
Dependabot: Ignore Refractor updates
3982244 
see #2341
@michalsanger michalsanger mentioned this issue May 10, 2021
Merged
kodiakhq bot pushed a commit that referenced this issue May 10, 2021
@michalsanger @kodiakhq
Dependabot: Ignore Refractor updates
3508d65 
see #2341
mrtnzlml added a commit that referenced this issue May 21, 2021
@mrtnzlml
Explicitly mark all packages with commonjs type
484d88e 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: #2341
@mrtnzlml mrtnzlml mentioned this issue May 21, 2021
Merged
mrtnzlml added a commit that referenced this issue May 21, 2021
@mrtnzlml
Explicitly mark all packages with commonjs type
588f5aa 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: #2341
kodiakhq bot pushed a commit that referenced this issue May 21, 2021
@mrtnzlml @kodiakhq
Explicitly mark all packages with commonjs type
7288ec2 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: #2341
adeira-github-bot pushed a commit to adeira/babel-preset-adeira that referenced this issue May 21, 2021
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
8401240 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
adeira-github-bot pushed a commit to adeira/css-colors that referenced this issue May 21, 2021
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
225c7f8 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
adeira-github-bot pushed a commit to adeira/eslint-config-adeira that referenced this issue May 21, 2021
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
c441055 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
adeira-github-bot pushed a commit to adeira/eslint-fixtures-tester that referenced this issue May 21, 2021
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
4af5e0a 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
adeira-github-bot pushed a commit to adeira/eslint-plugin-sx that referenced this issue May 21, 2021
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
90ec217 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
adeira-github-bot pushed a commit to adeira/fetch that referenced this issue May 21, 2021
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
6f1cbf9 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
adeira-github-bot pushed a commit to adeira/flow-config-parser that referenced this issue May 21, 2021
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
369bee1 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
adeira-github-bot pushed a commit to adeira/js that referenced this issue May 21, 2021
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
6f093d9 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
adeira-github-bot pushed a commit to adeira/monorepo-npm-publisher that referenced this issue May 21, 2021
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
e3ad38a 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
adeira-github-bot pushed a commit to adeira/monorepo-utils that referenced this issue May 21, 2021
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
133af47 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
adeira-github-bot pushed a commit to adeira/relay that referenced this issue May 21, 2021
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
2dcfcc3 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
adeira-github-bot pushed a commit to adeira/sx-design that referenced this issue May 21, 2021
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
6882396 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
adeira-github-bot pushed a commit to adeira/sx-jest-snapshot-serializer that referenced this issue May 21, 2021
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
6e2dc26 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
adeira-github-bot pushed a commit to adeira/sx that referenced this issue May 21, 2021
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
bd895da 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
adeira-github-bot pushed a commit to adeira/graphql-bc-checker that referenced this issue Jun 13, 2021
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
395378f 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
adeira-github-bot pushed a commit to adeira/sx-tailwind that referenced this issue Jun 26, 2021
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
fcf1306 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
adeira-github-bot pushed a commit to adeira/fixtures-tester that referenced this issue Jul 6, 2021
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
e31af89 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
mrtnzlml added a commit that referenced this issue Dec 8, 2021
@mrtnzlml
Dependabot: disable chalk dependency
bc2d35d 
It's a pure ESM package, see: #2341
@mrtnzlml mrtnzlml mentioned this issue Dec 8, 2021
Merged
mrtnzlml added a commit that referenced this issue Dec 8, 2021
@mrtnzlml
Dependabot: disable chalk dependency
7ddf2c6 
It's a pure ESM package, see: #2341
kodiakhq bot pushed a commit that referenced this issue Dec 9, 2021
@mrtnzlml @kodiakhq
Dependabot: disable chalk dependency
87dd768 
It's a pure ESM package, see: #2341
adeira-github-bot pushed a commit to adeira/babel-plugin-transform-sx-tailwind that referenced this issue Apr 30, 2022
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
62ab872 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
adeira-github-bot pushed a commit to adeira/graphql-resolve-wrapper that referenced this issue May 8, 2022
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
5b134e7 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
adeira-github-bot pushed a commit to adeira/graphql-relay-fauna that referenced this issue Jun 16, 2022
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
14ae97d 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
adeira-github-bot pushed a commit to adeira/graphql-relay that referenced this issue Jun 16, 2022
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
ad43d40 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
adeira-github-bot pushed a commit to adeira/graphql-global-id that referenced this issue Jun 16, 2022
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
1e40e3e 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
adeira-github-bot pushed a commit to adeira/signed-source that referenced this issue Jun 23, 2022
@mrtnzlml @adeira-github-bot
Explicitly mark all packages with commonjs type
78f5500 
See: https://nodejs.org/api/packages.html#packages_determining_module_system

> Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

Related issue: adeira/universe#2341

adeira-source-id: 7288ec22447e6de87afa3b2c0d510eb52772ecb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrtnzlml @michalsanger