Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate statements sent and LRS not connected on language changes #132

Closed
kevindoherty30 opened this issue Sep 17, 2024 · 1 comment
Closed

Comments

@kevindoherty30
Copy link

Subject of the issue

Duplicate xAPI statements are sent when a user changes language and LRS not connected message is triggered

Your environment

  • Framework 5.40.10 (and earlier)
  • All browsers
  • All devices/OS
  • xAPI v1.1.8 (and earlier)
  • Language Picker v5.5.3

Steps to reproduce

Create a multi-language course with any components but a simple test is to create a single page with a text component and accordion component on the languages
Add xAPI extension
Download
Test on platform with LRS connected
Select language from lang picker screen
Click on switch language icon
choose another language
view the page, view the text component and complete accordion component

Expected behaviour

We should receive one completed statement for the text component and one completed statement for the accordion component

Actual behaviour

We receive two statements for each component, ms apart

###Additional information:
If you switch languages again, an LRS not connected message appears, but if you then complete the components you will see new statements sent to the LRS - but instead of 2 per component it now increases to 4 per component.
The more you switch the more duplicate statements get generated, and the more times the LRS not connected message is generated when the language is switched - you need to click multiple times to dismiss

@lemmyadams lemmyadams moved this from New to Needs Reviewing in adapt_framework: The TODO Board Sep 25, 2024
github-actions bot pushed a commit that referenced this issue Sep 27, 2024
## [1.1.9](v1.1.8...v1.1.9) (2024-09-27)

### Fix

* Removing existing listeners before language change then re-add #132 (#133) ([ae8da86](ae8da86)), closes [#132](#132) [#133](#133)
@kevindoherty30
Copy link
Author

This has been resolved with the work done #132 and on release version https://github.com/adaptlearning/adapt-contrib-xapi/releases/tag/v1.1.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant