Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include articles in bg-color mixin #539

Open
swashbuck opened this issue Dec 18, 2024 · 0 comments · May be fixed by #540
Open

Include articles in bg-color mixin #539

swashbuck opened this issue Dec 18, 2024 · 0 comments · May be fixed by #540
Assignees
@swashbuck
Labels
enhancement

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Dec 18, 2024 •
edited
Loading

Subject of the enhancement

Articles should work with the bg-color mixin. Currently, the content in an article header is not included. Only blocks and components are targeted.

adapt-contrib-vanilla/less/project/theme-common.less

Lines 18 to 27 in b886dfe

.bg-color.@{color} {
background-color: @@color;
color: @@color-inverted;
.block,
.component {
&__title,
&__body a,
&__instruction a {
color: @@color-inverted;

It is also mentioned that the class can be added to articles, but this is not true.

adapt-contrib-vanilla/less/project/theme-common.less

Line 6 in b886dfe

// Can be added to course, contentObject, article, block, or component to enable

There is an ongoing discussion in #304 . For now, I think we should just include articles in the existing mixin.

Steps to reproduce

  1. Add a bg-color class to an article
  2. Add displayTitle, body, and instruction to the article

Expected behaviour

Text colors should be changed in the article header text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
enhancement
Projects
adapt_framework: The TODO Board
Status: Needs Reviewing
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Add article to bg-color mixin (fix #539) adaptlearning/adapt-contrib-vanilla
1 participant
@swashbuck