Extra breakpoints required. Missing xlarge.

[StuartNicholls]

Following the breakpoint update in core, we need to add in an extra large node for headers and backgrounds.

adapt-contrib-vanilla/js/themePageView.js

Lines 46 to 55 in aac3a2b

	switch (Adapt.device.screenSize) {
	case 'large':
	backgroundImage = backgroundImages._large;
	break;
	case 'medium':
	backgroundImage = backgroundImages._medium;
	break;
	default:
	backgroundImage = backgroundImages._small;
	}

linked to issue #430

We could add this issue in now and retain the existing functionality. See issue #430 as functionality may get updated at a later date in this issue.

[oliverfoster]

That code can mimic the boxMenu code, which is much simpler, less hard-codey and does the same thing:

https://github.com/adaptlearning/adapt-contrib-boxMenu/blob/040166743e2a765a7d08bd5b4e6b08a7705ecf64/js/BoxMenuView.js#L73

It's a nice one-liner.

There's also the responsiveClasses and minimumHeights configs too.

[StuartNicholls]

@oliverfoster yep, lovely

[github-actions]

🎉 This issue has been resolved in version 9.6.15 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀