Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trickle button not showing when assessment has been completed #221

Closed
joe-allen-89 opened this issue May 13, 2024 · 1 comment · Fixed by #222
Closed

Trickle button not showing when assessment has been completed #221

joe-allen-89 opened this issue May 13, 2024 · 1 comment · Fixed by #222
Assignees
@joe-allen-89
Labels
bug released

Comments

@joe-allen-89
Copy link
Contributor

Subject of the issue/enhancement/features

With a recent change to filter out globally removed models (adaptlearning/adapt-contrib-assessment#196) the trickle button is now not showing when an assessment has been completed.

Your environment

  • FW latest
  • Firefox/Chrome

Steps to reproduce

Create assessment article with a trickle button at the end and another article with the results, complete the assessment.

Expected behaviour

Trickle button should become visible

Actual behaviour

No trickle button, user gets stuck
@joe-allen-89 joe-allen-89 self-assigned this May 13, 2024
@joe-allen-89 joe-allen-89 mentioned this issue May 13, 2024
Closed
@joe-allen-89 joe-allen-89 linked a pull request May 13, 2024 that will close this issue
Fix: Include check for model.get('_type') !== 'block' when filtering models (fixes #197) adaptlearning/adapt-contrib-assessment#198
Closed
@joe-allen-89 joe-allen-89 transferred this issue from adaptlearning/adapt-contrib-assessment May 15, 2024
@joe-allen-89 joe-allen-89 mentioned this issue May 15, 2024
Merged
@joe-allen-89 joe-allen-89 linked a pull request May 15, 2024 that will close this issue
Fix: Add trickle button to data collection (fixes #221) #222
Merged
@github-project-automation github-project-automation bot moved this from Assigned to Recently Released in adapt_framework: The TODO Board May 15, 2024
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 7.3.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joe-allen-89 joe-allen-89

Labels
bug released
Projects
None yet
Milestone
No milestone
1 participant
@joe-allen-89