Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsupported logic #304

Closed
danielghost opened this issue Dec 11, 2023 · 1 comment · Fixed by #306
Closed

Unsupported logic #304

danielghost opened this issue Dec 11, 2023 · 1 comment · Fixed by #306
Assignees
@danielghost
Labels
bug released

Comments

@danielghost
Copy link
Contributor

In addition to the changes made for #302, the unsupported logic should change to check which child elements are supported, as per the spec:

datamodel.element._children
The _children keyword is used to determine all of the elements in a group or category that are supported by the LMS.

LMSGetValue(datamodel.group._children)
The return value is a comma-separated list of all of the element names in the specified group or category that are supported by the LMS. If an element has no children, but is supported, an empty string ("") is returned. An empty string ("") is also returned if an element is not supported. A subsequent request for last error [LMSGetLastError()] can determine if the element is not supported. The error “401 Not implemented error” indicates the element is not supported.

The current method of just checking _count could lead to errors being raised where not all the child elements are supported.
@danielghost danielghost self-assigned this Dec 11, 2023
@danielghost danielghost moved this from New to Assigned in adapt_framework: The TODO Board Dec 11, 2023
danielghost added a commit that referenced this issue Dec 11, 2023
@danielghost
Fix: Amended logic to check for supported _children elements before…
583ccaa 
… attempting to set values (fixes #304).
@danielghost danielghost mentioned this issue Dec 11, 2023
Merged
@danielghost danielghost moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Dec 11, 2023
@oliverfoster oliverfoster moved this from Needs Reviewing to Assigned in adapt_framework: The TODO Board Dec 19, 2023
@danielghost danielghost moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Jan 3, 2024
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Jan 18, 2024
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 5.9.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielghost danielghost

Labels
bug released
Projects
None yet
Milestone
No milestone
1 participant
@danielghost