Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error messaging lost if course is not yet loaded #300

Closed
danielghost opened this issue Dec 1, 2023 · 1 comment · Fixed by #301
Closed

Error messaging lost if course is not yet loaded #300

danielghost opened this issue Dec 1, 2023 · 1 comment · Fixed by #301
Assignees
@danielghost
Labels
bug released

Comments

@danielghost
Copy link
Contributor

If an error occurs before Adapt.course has loaded, the error message will be lost. Instead of returning early as per the changes in cb3d93f, the error handling should be delayed by adding:

if (!Data.isReady) await Data.whenReady();
@danielghost danielghost added the bug label Dec 1, 2023
@danielghost danielghost self-assigned this Dec 1, 2023
@danielghost danielghost mentioned this issue Dec 1, 2023
Merged
@danielghost danielghost moved this from New to Needs Reviewing in adapt_framework: The TODO Board Dec 1, 2023
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Dec 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

🎉 This issue has been resolved in version 5.9.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielghost danielghost

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: delay error messaging until all course data is ready adaptlearning/adapt-contrib-spoor
1 participant
@danielghost