Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible issue if course.json does not contain "_spoor" element #299

Closed
paulstevendev opened this issue Nov 28, 2023 · 3 comments
Closed
Assignees
Labels

Comments

@paulstevendev
Copy link
Contributor

When testing in the authoring tool using the latest adapt-contrib-spoor I do not see any reference to "_spoor" in the course.json file of the published SCORM zip file.

Therefore I question whether this is going to cause an issue here:

const config = Adapt.course.get('_spoor');

https://github.com/adaptlearning/adapt-contrib-spoor/blob/4370780b00d734819159acb866ace308d5ec59f0/js/scorm/wrapper.js#L549C1-L551C74

The code will hang here surely if there is no "_spoor" element present in course.json

@paulstevendev
Copy link
Contributor Author

Possibly related to this issue
#283

@paulstevendev
Copy link
Contributor Author

course.json
Attached course.json from published course from open source authoring tool using Spoor 5.9.3 and the following
Adapt authoring tool 0.11.2.
Adapt framework v5.33.4
You will see there is no "_spoor" element in course.json

@oliverfoster
Copy link
Member

Confirmed working with no _spoor in course.json now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants