Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is an empty string the desired cmi.core.exit value if default of auto used? #297

Open
paulstevendev opened this issue Nov 13, 2023 · 1 comment

Comments

@paulstevendev
Copy link
Contributor

Just wanted to check this is the desired functionality. If you leave the "Exit state if incomplete" and "Exit state if complete" set to "auto" the exit state ends up being an empty string ""

https://github.com/adaptlearning/adapt-contrib-spoor/blob/f07a6032a687b6653c4dbcd903797663fa3ec665/js/scorm/wrapper.js#L934C1-L941C4

Doesn't seem very auto to me. Surely if it is auto it should have a stab at setting it to the most appropriate value kind of like how the pipwerks code does it

https://github.com/adaptlearning/adapt-contrib-spoor/blob/f07a6032a687b6653c4dbcd903797663fa3ec665/libraries/SCORM_API_wrapper.js#L398C1-L423C1

@danielghost
Copy link
Contributor

SCORM 1.2 will use an empty string. SCORM 2004 will use "suspend" until "completed", then switch to "normal".

When using SCORM 1.2, it seems like the default for most LMSs is to restore the previous state regardless when using an empty string for cmi.core.exit. This isn't the case when using SCORM 2004, which requires the addition of "_exitStateIfComplete": "suspend" in config.json to prevent the runtime data from being reset once completed.

An LMS may have configuration to ignore the cmi.core.exit/cmi.exit values determined by the SCO, but I would suggest that as default we use "suspend" at all times so the runtime data is restored consistently regardless of which SCORM version is used.

@danielghost danielghost moved this from New to Awaiting Response in adapt_framework: The TODO Board Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Awaiting Response
Development

No branches or pull requests

3 participants