Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AAT: Clarify how _showPageCompletion works #215

Closed
swashbuck opened this issue Apr 3, 2024 · 1 comment · Fixed by #219
Closed

AAT: Clarify how _showPageCompletion works #215

swashbuck opened this issue Apr 3, 2024 · 1 comment · Fixed by #219
Assignees
@swashbuck
Labels
documentation Improvements or additions to documentation enhancement released

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Apr 3, 2024 •
edited
Loading

Subject of the enhancement

In 2018, a question/suggestion was posted to the PLP wiki which I have just removed:

In the setting dialog below (found on the Page level settings in the authoring tool), the following text appears to need clarification:

"Show page completion: [] Controls whether the progress calculations for this page are based on all components - or only those that are set to be displayed in Page Level Progress."

Please reword so it's clearer what clicking the box DOES -- does TRUE mean it will calculate completion for all components or just selected ones?

In the readme, it is more explicit about how the setting works:

Set to false to have the overall progress calculated only from components that have been set to display in Page Level Progress (ignoring the completion of those that have not).

The description in the schemas could be reworded to something along these lines to make it clearer.
@swashbuck swashbuck added documentation Improvements or additions to documentation enhancement labels Apr 3, 2024
@swashbuck swashbuck self-assigned this May 16, 2024
@swashbuck swashbuck moved this from New to Assigned in adapt_framework: The TODO Board May 16, 2024
@swashbuck swashbuck mentioned this issue May 16, 2024
Merged
@swashbuck swashbuck moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board May 16, 2024
kirsty-hames pushed a commit that referenced this issue May 30, 2024
@swashbuck
Fix: Clarify _showPageCompletion functionality (fixes #215) #219
060e88c
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board May 30, 2024
github-actions bot pushed a commit that referenced this issue May 30, 2024
@semantic-release-bot
Chore(release): 7.6.3 [skip ci]
b167625 
## [7.6.3](v7.6.2...v7.6.3) (2024-05-30)

### Fix

* Clarify _showPageCompletion functionality (fixes #215) #219 ([060e88c](060e88c)), closes [#215](#215) [#219](#219)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 7.6.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
documentation Improvements or additions to documentation enhancement released
Projects
None yet
Milestone
No milestone
1 participant
@swashbuck