Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlighting an MCQ item causes a re-render which removes any applied classes #225

Closed
lemmyadams opened this issue Sep 27, 2024 · 3 comments
Closed

Highlighting an MCQ item causes a re-render which removes any applied classes #225

lemmyadams opened this issue Sep 27, 2024 · 3 comments
Assignees
@lemmyadams
Labels
bug

Comments

@lemmyadams
Copy link
Contributor

Subject of the issue/enhancement/features

When using tab to navigate to an MCQ item, it causes a reset on the component, which removes any added classes.

Propose to fire an adapt event when on item focus and item blur so any functionality used to apply classes can listen to this event and reapply.
@lemmyadams lemmyadams added the bug label Sep 27, 2024
@lemmyadams lemmyadams self-assigned this Sep 27, 2024
@lemmyadams lemmyadams moved this from New to Assigned in adapt_framework: The TODO Board Sep 27, 2024
@oliverfoster
Copy link
Member

It would be better if you added classes to items through the model.

@lemmyadams
Copy link
Contributor Author

@oliverfoster okay thanks

@lemmyadams lemmyadams mentioned this issue Sep 27, 2024
Closed
@lemmyadams lemmyadams moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Sep 27, 2024
@lemmyadams
Copy link
Contributor Author

Closing because we can just listen to change:isHighlighted instead, so no mcq change required

@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lemmyadams lemmyadams

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliverfoster @lemmyadams