Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not correctly calculate if effectively complete on block completion #63

Closed
oliverfoster opened this issue Aug 14, 2024 · 1 comment · Fixed by #64
Closed

Does not correctly calculate if effectively complete on block completion #63

oliverfoster opened this issue Aug 14, 2024 · 1 comment · Fixed by #64
Assignees
@oliverfoster
Labels
bug Something isn't working released

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Aug 14, 2024 •
edited
Loading

Subject of the issue

https://github.com/adaptlearning/adapt-contrib-branching/blob/fb3ebe73e1130943b0a3754b894f427c6842b29b/js/adapt-contrib-branching.js#L152C3-L162C4

This function works well for components but is also called on blocks. It should calculate correctly on blocks.
@oliverfoster oliverfoster added the bug Something isn't working label Aug 14, 2024
@oliverfoster oliverfoster self-assigned this Aug 14, 2024
oliverfoster added a commit that referenced this issue Aug 14, 2024
@oliverfoster
Fix: Correctly calculate effective completion on blocks (fixes #63)
c4d105b
@oliverfoster oliverfoster mentioned this issue Aug 14, 2024
Merged
@oliverfoster oliverfoster moved this from New to Needs Reviewing in adapt_framework: The TODO Board Aug 14, 2024
joe-allen-89 pushed a commit that referenced this issue Sep 2, 2024
@oliverfoster
Fix: Correctly calculate effective completion on blocks (fixes #63) (#64
220aadd 
)

* Fix: Correctly calculate effective completion on blocks (fixes #63)

* Changed variable names for clarity
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Sep 2, 2024
github-actions bot pushed a commit that referenced this issue Sep 2, 2024
@semantic-release-bot
Chore(release): 1.3.3 [skip ci]
0378a2f 
## [1.3.3](v1.3.2...v1.3.3) (2024-09-02)

### Fix

* Correctly calculate effective completion on blocks (fixes #63) (#64) ([220aadd](220aadd)), closes [#63](#63) [#64](#64) [#63](#63)
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

🎉 This issue has been resolved in version 1.3.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverfoster oliverfoster

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
1 participant
@oliverfoster