-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all modules' peerDependencies #493
Comments
@taylortom I've taken down the comments I added to make some revisions - will post back soon. |
UPDATE on the below comments: at present I am correcting dependencies across packages and adding Peer dependencies are for plugin architectures. The AAT doesn't implement a plugin architecture: it is a single application split across packages. These packages have a mix of import and runtime interdependencies. Most packages are therefore coupled and some tightly (jsonschema <-> config, content <-> contentplugin). Propose the following:
This will mean we have a single place to change paths (e.g. select a different Git branch) for whatever dependencies we like and therefore not have resolution conflicts when we are using Node workspaces. For example, if I am working on adaptframework issue/31, and content issue/23 (but from a different Git user) I can just edit one
|
As discussed with Ollie, we'll keep nested dependencies to allow for simpler installations and a more transparent dependency map. After running a few tests on peer dependencies, I agree that they introduce more problems than they solve, so think we need to forget that approach for now. I do still think we need a way for developers to flag when certain modules are used at runtime to give useful warnings to the user. |
Need to make sure all module interdependencies are defined using the
peerDependencies
object.This includes the following:
waitForModule
See this article for a bit of an explanation.
The text was updated successfully, but these errors were encountered: