Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup core template files #58

Open
adampatterson opened this issue Jan 31, 2022 · 1 comment
Open

Cleanup core template files #58

adampatterson opened this issue Jan 31, 2022 · 1 comment
Labels
enhancement

Comments

@adampatterson
Copy link
Owner

Can we move everything into some nice class names like Content::single() for example?

Will ACF still work?
adampatterson added a commit that referenced this issue Jan 31, 2022
@adampatterson
closes #58 moves the root tempalte logic into a class cleaning up the…
6302da1 
… files
@adampatterson
Copy link
Owner Author

Not 100% sold that this is a good move. Reduces flexibility in how extra ACF data can be loaded in child themes.

Might be more viable if there was a model approach to the data rather than relying on included files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adampatterson