Raise our own utcnow DeprecationWarning with the right stacklevel
#486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when time is mocked, no DeprecationWarning would be reported at all, and when time is not mocked, the original datetime.utcnow would misattribute its reported DeprecationWarning to the code of time_machine itself. Fix both cases to attribute the DeprecationWarning to the user code that called utcnow, by raising it ourselves with the right stacklevel, and test that we did so correctly. Fixes adamchainz#445. Signed-off-by: Anders Kaseorg <[email protected]>
andersk
force-pushed
the
deprecated-utcnow
branch
from
8dd2a43
to
3605afd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when time is mocked, no
DeprecationWarningwould be reported at all, and when time is not mocked, the originaldatetime.utcnowwould misattribute its reportedDeprecationWarningto the code oftime_machineitself. Fix both cases to attribute theDeprecationWarningto the user code that calledutcnow, by raising it ourselves with the rightstacklevel, and test that we did so correctly.