Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Make 404 pages package-specific #77

Open
nex3 opened this issue Jun 17, 2014 · 3 comments
Open

Make 404 pages package-specific #77

nex3 opened this issue Jun 17, 2014 · 3 comments

Comments

@nex3
Copy link

nex3 commented Jun 17, 2014

The default 404 page is used for all 404 pages, including those for packages whose documentation failed to build. Since the server knows the package and version that the user is requesting, it would be nice if it would look up the corresponding build log and include a link (or better, render it inline) along with instructions about how to fix the issue.

@adam-singer
Copy link
Owner

@nex3 will look into this. All content is served up from Cloud Storage. I think we could make the 404.html page more lively by running some client side script code to look at the query url and fetch the logs.

@nex3
Copy link
Author

nex3 commented Jun 17, 2014

Another possibility would be to upload a custom error page for every build that fails.

@adam-singer
Copy link
Owner

@nex3 I do like that idea. This would also be related to the following issue #54

Downside is it would require a full build of failed packages to be done. Could script around this by doing a custom datastore query and adding those packages to a queued build. Doing it all in one shot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants