Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for circuitpython-build-bundles #89

Open
Neradoc opened this issue Jun 20, 2022 · 3 comments
Open

Add tests for circuitpython-build-bundles #89

Neradoc opened this issue Jun 20, 2022 · 3 comments

Comments

@Neradoc
Copy link
Contributor

Neradoc commented Jun 20, 2022

Add tests to the PR build workflow in order to catch errors and malformed bundles.

@jepler
Copy link
Member

jepler commented Jun 27, 2022

There's currently a "test" in Actions, but it only checks that the build process exits with a zero status. However, due to some recent issues it appears that we need to check something about the actual content of the .mpy files that are generated.

@jepler
Copy link
Member

jepler commented Nov 27, 2024

@FoamyGuy do you have any interest in grabbing this?

@jepler jepler removed their assignment Nov 27, 2024
@FoamyGuy
Copy link
Contributor

FoamyGuy commented Dec 2, 2024

I'll add this to my list to look into. It's got a few things ahead of it so it may be a little bit.

@jepler or @Neradoc do either you have an idea in mind for what kind of validation we'd want to do on the mpy file? The only that come to mind for me are check that the size isn't 0, and maybe try importing it under the unix port though I don't know if that will be possible for every library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants