Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

malformed external_dependencies (edge-case) #80

Open
2bndy5 opened this issue Sep 17, 2021 · 0 comments
Open

malformed external_dependencies (edge-case) #80

2bndy5 opened this issue Sep 17, 2021 · 0 comments

Comments

@2bndy5
Copy link
Contributor

2bndy5 commented Sep 17, 2021

I have a CirPy lib that uses spidev on Linux (yields much better performance than pureio). I have listed spidev in the lib's requirements.txt like so

adafruit-circuitpython-busdevice
spidev; sys_platform == 'linux'

The ; sys_platform == 'linux' is advice taken from pip's docs, but this makes the bundle's JSON external_dependencies look like so:

        "external_dependencies": [
            "adafruit-circuitpython-busdevice",
            "spidev; sys_platform "
        ]

I'm mandating the spidev module on Linux only because linting the lib when developing requires that the development changes be installed (spidev can't be installed on Windows). Granted, I still have to ignore warnings about import spidev in my lib's examples, but that's what hardware testing is for.

Feel free to close this issue if there are no foreseen consequences with circuitpython.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant