@imnotjames I thought I saw some questions from you about where to add exceptions, how close we should adhere to CPython, etc., but I cannot find them. Did you ask them here and then delete them? I cannot find them in discord either.

_asyncio is supposed to be optional, so this library should be able to work without it. Hence the guarded imports for _asyncio.

@dhalbert No worries! It was in discord, there was a bit of a wall of text and then a question, so totally understandable to miss it.

But onto a bit of a question -- if I'm implementing some python methods in C and need it to throw an error - in this case CancelledError - do I need that error available at runtime or compile time? In other words, do I need to pull that out of the asyncio external module and implement an error in _asyncio?

I think during compile time so I'd have to define it as part of the modasyncio.c but I'm not the most familiar with circuitpython internals.

If they are needed during compile time then it means I'd move CancelledError & InvalidStateError into task.py + implement them as well in the optional _asyncio.

I might have answered my own question via some attempts to make it work any other way, though -- I can't find a way to reference the CancelledError from C without having it be there during compile time. If there's some way I'm missing, though, definitely interested to learn more.

Got it. Any exception referenced by C has to be defined in C (or else defined at runtime in some tortuous way, which we wouldn't normally do). So definitely just define it like the other _asyncio C exceptions.