Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-dm-tree(-git)] fails to build #245

Open
moghingold opened this issue Jun 9, 2023 · 9 comments · Fixed by #247
Open

[python-dm-tree(-git)] fails to build #245

moghingold opened this issue Jun 9, 2023 · 9 comments · Fixed by #247

Comments

@moghingold
Copy link

This is the output of makepkg -i on AUR target python-dm-tree: https://pastebin.com/NUpMyc3t

I get similar results with target python-dm-tree-git. The strange thing is that this package seems to be trying to download and build abseil-cpp, which is available as a separate AUR package (abseil-cpp-git) and had no build issues when I installed it separately.

Is there an upstream issue, or does there seem to be something hinky with my system configuration?

@moghingold
Copy link
Author

Very similar output for makepkg -i on AUR target python-dm-tree-git: https://pastebin.com/GkrhpvEM

@moghingold
Copy link
Author

Can also now confirm that the problem persists between boots. So if it's an issue with my system state then it isn't a temporary one.

@tiagocpontesp
Copy link

can confirm

@intelfx
Copy link
Contributor

intelfx commented Jun 15, 2023

Barring the actual problem (CMakeLists.txt seems to be written either incorrectly or at least using deprecated techniques no longer recommended by CMake upstream), abseil-cpp is available as a normal repo package. Thing is, abseil upstream strongly discourages dependents from linking to external copies of abseil. On the other hand, no one has died yet from using the abseil-cpp in Arch repos.

@moghingold
Copy link
Author

But I installed abseil-cpp and python-dm-tree still tries to build it anyways. It's not detecting and using the installed version. So the build script seems doubly-wrong. Is there an upstream I should take this info to? Or is this addressable through the PKGBUILD?

@intelfx
Copy link
Contributor

intelfx commented Jun 15, 2023

@moghingold yes, it is trying to build its own abseil-cpp unconditionally. This is addressable through the PKGBUILD by de-vendoring abseil, at the cost of making this package dependent on system abseil-cpp.

Alternatively, the build system can be modified to vendor abseil-cpp correctly, but I am uninterested in doing that :)

@acxz acxz closed this as completed in #247 Jun 22, 2023
@acxz
Copy link
Owner

acxz commented Jun 22, 2023

Keeping this open until the patch is not needed.

@acxz acxz reopened this Jun 22, 2023
@acxz
Copy link
Owner

acxz commented Jun 22, 2023

patched with #247

@acxz acxz changed the title [python-dm-tree] fails to build [python-dm-tree(-git)] fails to build Jun 22, 2023
@xangelix
Copy link

xangelix commented Jun 25, 2023

please bump pkgrel in the future to make sure people actually get the fix
thank you though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants