Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maintenance][TS] Add missing Modal type #1940

Closed
MatissJanis opened this issue Nov 20, 2023 · 1 comment
Closed

[Maintenance][TS] Add missing Modal type #1940

MatissJanis opened this issue Nov 20, 2023 · 1 comment
Labels
maintenance Related to making the project easier to maintain

Comments

@MatissJanis
Copy link
Member

When reviewing #1885 I noticed that we do not have a Modal type. It is currently inferred as any.

Currently it is used in a few places. For example:

actual/packages/loot-core/src/client/state-types/modals.d.ts

Line 124 in 4761e9c

modalStack: Modal[];

The goal would be to bring it back (it was removed here). This will mean re-introducing the strict type AND fixing the issues that will arise.
@MatissJanis MatissJanis added help wanted Extra attention is needed maintenance Related to making the project easier to maintain labels Nov 20, 2023
@MatissJanis MatissJanis changed the title [Maintenance] Add missing Modal type [Maintenance][TS] Add missing Modal type Nov 20, 2023
MatissJanis added a commit that referenced this issue Dec 4, 2023
@MatissJanis
♻️ (typescript) making Modals typing more strict
76a09ce 
Closes #1940
@MatissJanis MatissJanis mentioned this issue Dec 4, 2023
Closed
@MatissJanis
Copy link
Member Author

Don't think this is applicable any more.

Related to TS migration: #1483

@MatissJanis MatissJanis closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
@github-actions github-actions bot removed the help wanted Extra attention is needed label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Related to making the project easier to maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] ♻️ (typescript) making Modals typing more strict actualbudget/actual
1 participant
@MatissJanis