Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip amount option with GoCardless #261

Open
parasdaryanani opened this issue Sep 4, 2023 · 12 comments
Open

Flip amount option with GoCardless #261

parasdaryanani opened this issue Sep 4, 2023 · 12 comments

Comments

@parasdaryanani
Copy link

HSBC UK credit card transactions synced with GoCardless show a positive balance, which is actually the remaining credit limit. Other credit cards like Amex and Barclaycard correctly show a negative balance. Is there a way to use the "flip amount" feature with GoCardless account sync?

@MatissJanis
Copy link
Member

I would recommend first reaching out to GoCardless and letting them know of this inconsistency. They are pretty quick to respond and resolve issues.

Let me know what they say!

@parasdaryanani
Copy link
Author

parasdaryanani commented Sep 5, 2023

@MatissJanis here is what they came back with:

HSBC_HBUKGB4B exposes 2 items under balances (for credit cards, at least):

{
    "balances": [
        {
            "balanceAmount": {
                "amount": "4183.61",
                "currency": "GBP"
            },
            "balanceType": "interimAvailable",
            "referenceDate": "2023-09-05"
        },
        {
            "balanceAmount": {
                "amount": "-316.39",
                "currency": "GBP"
            },
            "balanceType": "interimBooked",
            "referenceDate": "2023-09-05"
        }
    ]
}

It looks like Actual is using interimAvailable for current balance instead of interimBooked for cards.

@MatissJanis MatissJanis reopened this Sep 5, 2023
@MatissJanis
Copy link
Member

Interesting. Yea, we might not be properly handling credit cards. Or perhaps just your banks credit cards.. I don't have a CC, so can't check what I would get on my end sadly.

The bank adapters can be found here: https://github.com/actualbudget/actual-server/tree/master/src/app-gocardless/banks

Worst case: you can add a custom adapter specifically for your bank.

@dylmye
Copy link
Contributor

dylmye commented Sep 8, 2023

I can confirm this is the same with Santander UK credit cards (SANTANDER_GB_ABBYGB2L)

@parasdaryanani
Copy link
Author

I'll make some time to play around with this and see if I can implement a generic solution that will check for interimBooked, specifically for credit cards. Otherwise, custom bank adapter it is.

@jakoblover
Copy link
Contributor

jakoblover commented May 2, 2024

I am having the same issue with SEB_KORT_AB_NO_SKHSFI21, where purchases done with the card are positive and payments to the card are negative. I contacted GoCardless and this is the response I got:

Thanks for reaching out!
According to the bank - this is the expected behaviour for these transactions as they have been made from a credit card account and the amounts are referencing your credit limit balance.
If a debit card account would be connected the transactions would show up in the way you are expecting as then it would be referencing the debit balance.

Here is an example payment made to the credit card, which should be positive (but is negative in the json from gocardless)

 { 
"transactionId": "some_string_of_numbers", 
"bookingDate": "2024-03-20", 
"valueDate": "2024-03-20", 
"transactionAmount": { "amount": "-55901.91", "currency": "NOK" }, 
"additionalInformation": "INNBETALING BANKGIRO", 
"proprietaryBankTransactionCode": "PAYMENT", 
"internalTransactionId": "some_string_of_numbers_and_letters"
}

I see @walleb already made a bank adapter for SEB_KORT_AB_SE_SKHSFI21, but I think SEB_KORT_AB_NO_SKHSFI21 should work the same way.

@jzahedieh
Copy link

My Halifax credit card had this issue, I just added a transaction of the credit limit to reverse/flip/correct the account total into "Starting Balances" the payments are correctly putting the account into negative so it has resolved me issue.

image

@craigmdennis
Copy link
Contributor

It looks like the same is occurring with SEB Invited credit card (using SEB Card Accounts) in Sweden.
How can I find the institution ID to check if a custom adapter would work?

@apintocr
Copy link

apintocr commented Jul 8, 2024

How can we add a custom adapter?

@MatissJanis
Copy link
Member

@apintocr
Copy link

apintocr commented Aug 5, 2024

How can we add a custom adapter?

https://github.com/actualbudget/actual-server/blob/master/src/app-gocardless/README.md

Thank you for your reply.

How could I do this using the docker container while keeping it resistant to updates?

@jakoblover
Copy link
Contributor

You could either make a PR upstream or create a Docker image yourself with your applied changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants