Check and fix routing based on non-localized routes #963
Assignees
Labels
Comments
2 tasks
|
Hello @andrewtavis, could you please assign me to this issue? |
|
Hello @andrewtavis, could you please assign me to this issue as well? Thank you! |
aadityanairaaq
added a commit
to CMU-17313Q/ELEV8-activist
that referenced
this issue
Dec 11, 2024
…obust comparisons
aadityanairaaq
added a commit
to CMU-17313Q/ELEV8-activist
that referenced
this issue
Dec 11, 2024
…nctions by refining path identification functions.
aadityanairaaq
added a commit
to CMU-17313Q/ELEV8-activist
that referenced
this issue
Dec 11, 2024
…teUtils.ts by implementing helper functions and locals for each language for issue activist-org#963
andrewtavis
added a commit
that referenced
this issue
Dec 11, 2024
…ng-based-on-nonlocalized-routes * Fixed route highlighting in the left sidebar for localized routes (e.g., French, German). * fixing issue #963 through Locale Removal and using more robust comparisons * looked to refix issue #963 using adjustments to helper functions by refining path identification functions. * made changes to normalizePath function within routeUtils.ts to better remove leading slashes * created helper function for normalizePath in routeUtils.ts to improve readability * adjusted isRouteActive to better handle conditions and routing in routeUtils.ts by implementing helper functions and locals for each language for issue #963 --------- Co-authored-by: “Aya-Abdel-Hamid” <[email protected]>
|
Closed by #1059 and other related commits :) Thanks all for the great work! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Terms
Behavior
Because of the necessary change in #962, we now have non-localized routes for English as Netlify was breaking on them. We thus need to rework the way that routes are done to allow for non
/enroutes as well, so routes that lack any localization at all.I'll look into this!
The text was updated successfully, but these errors were encountered: