Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement groups api testing #828

Open
2 tasks done
andrewtavis opened this issue Apr 20, 2024 · 5 comments
Open
2 tasks done

Implement groups api testing #828

andrewtavis opened this issue Apr 20, 2024 · 5 comments
Assignees
Labels
feature New feature or request hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Apr 20, 2024

Terms

Description

Something that's needed to make sure that the test coverage is maintained for the backend is tests for the groups models. These could generally follow the example tests sent along in #824 and would be written in backend/entities/tests.py.

Contribution

Happy to answer questions or help implement as I can! 😊

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed labels Apr 20, 2024
@andrewtavis
Copy link
Member Author

CC @thiagogquinto, @to-sta and I were thinking this would be a good next issue to look into as he needed to take over #801 :) Let us know if this'd be something that'd interest you!

@andrewtavis andrewtavis added the hacktoberfest Included as a part of Hacktoberfest label Oct 1, 2024
@zeus2611
Copy link
Contributor

@andrewtavis I would like to take on this task if it’s not currently assigned. In the activist/backend/entities/models.py file, we have multiple group models, including Group, GroupEvent, GroupImage, GroupMember, GroupText, GroupResource, and GroupTopic. Writing tests for all these models in a single backend/entities/tests.py file would make the file quite large and complex. Would it be possible to create separate test files for each model, with a single file to run all the tests? This approach would be similar to what we implemented in #990.

@andrewtavis
Copy link
Member Author

Hey @zeus2611 👋 Sorry it seems like my extreme level of business a month ago meant that this comment totally slipped through... I think that splitting these tests up into multiple files would be fine :) If you'd still have interest in working on it, we'd welcome a PR! 😊

@zeus2611
Copy link
Contributor

zeus2611 commented Nov 23, 2024

Hey @andrewtavis, I started working on this issue. Can you please assign this to me?

@andrewtavis
Copy link
Member Author

Sure thing, @zeus2611! Let us know if we can support, and appreciate you picking it up! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

2 participants