Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'role' attribute to hidden tag fields of payment service form. #11

Open
ntalbott opened this issue Jun 4, 2014 · 0 comments
Open

Comments

@ntalbott
Copy link
Contributor

ntalbott commented Jun 4, 2014

Issue by divineforest
Friday Oct 11, 2013 at 09:30 GMT
Originally opened as https://github.com/Shopify/active_merchant/pull/878


Without this change it's not possible to programmatically find these input elements by Javascript integration-independently because fields like "order" will have other actual names as set by particular service mappings.

With this patch "order" input for example for Paysbuy integration will be:

<input id="inv" name="inv" role="payment-form-order" type="hidden" value="42">

So I can query it with

$("[role='payment-form-order']")

without having to know particular input name.

More info on "role" html attribute http://www.w3.org/TR/role-attribute/


divineforest included the following code: https://github.com/Shopify/active_merchant/pull/878/commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant