Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat req] Merge action should support if-no-files-found #520

Open
comp615 opened this issue Feb 13, 2024 · 0 comments · May be fixed by #521
Open

[feat req] Merge action should support if-no-files-found #520

comp615 opened this issue Feb 13, 2024 · 0 comments · May be fixed by #521
Labels
enhancement New feature or request

Comments

@comp615
Copy link

comp615 commented Feb 13, 2024

What would you like to be added?

Please add the same behavior of if-no-files-found from the main action to the merge action

Why is this needed?

Many matrixed workflows conditionally generate artifacts (i.e. Cypress videos or snapshots). The previous pattern in v3 was to simply upload artifact and set if-no-files-found: ignore. If there's artifacts, great...if not, no problem.

Given that the solution to accomplish the same task in v4 is to use the merge action. There should be a matching param so that in the event all the matrixed tests pass without issue, the merge job doesn't fail.

Try It

      - name: Merge Artifacts
        uses: comp615/upload-artifact/merge@merge_not_found
        with:
          name: cypress-videos
          pattern: cypress-videos-*
          delete-merged: true
          if-no-files-found: ignore
@comp615 comp615 added the enhancement New feature or request label Feb 13, 2024
@comp615 comp615 linked a pull request Feb 13, 2024 that will close this issue
DanTup added a commit to Dart-Code/Dart-Code that referenced this issue Feb 22, 2024
merge has no if-files-not-found so try skipping errors when this happens.

actions/upload-artifact#520 / actions/upload-artifact#521 might allow us to change this in future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant