-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the EDGEDRIVER_VERSION environment variable #10380
Comments
These can also be changed to print the EDGEDRIVER_VERSION environment variable as well:
runner-images/images/macos/scripts/docs-gen/SoftwareReport.Browsers.psm1 Lines 99 to 102 in e15a279
runner-images/images/windows/scripts/docs-gen/SoftwareReport.Browsers.psm1 Lines 82 to 85 in e15a279
|
Hi @danielhjacobs , we will be checking the issue and provide solutions ,Thanks |
This has been circumvented downstream in npm's edgedriver by webdriverio-community/node-edgedriver@68043fe which is included in https://github.com/webdriverio-community/node-edgedriver/releases/tag/5.6.1, so if you use webdriverio with edgedriver you can circumvent this issue by updating the webdriverio-related and edgedriver dependencies. However, it would be better if the environment variable were set so this wouldn't have to go through the complicated logic of:
|
Hi @danielhjacobs , The need to set the environment cannot be implemented at our end, |
Description
This uses that environment variable:
https://github.com/webdriverio-community/node-edgedriver/blob/7b2b44946f422b86e4c937d277f412a380394a1c/src/install.ts#L24
I believe it can be set on Mac by adding to this:
runner-images/images/macos/scripts/build/install-edge.sh
Line 36 in e15a279
I believe it can be set on Windows by adding to this:
runner-images/images/windows/scripts/build/Install-EdgeDriver.ps1
Line 34 in e15a279
I believe it can be set on Ubuntu by adding to this:
runner-images/images/ubuntu/scripts/build/install-microsoft-edge.sh
Line 48 in e15a279
Relates to #10336, MicrosoftEdge/EdgeWebDriver#156, and webdriverio-community/node-edgedriver#365
Platforms affected
Runner images affected
Image version and build link
20240721.1.0
https://github.com/ruffle-rs/ruffle/actions/runs/10068053329/job/27832705746
Is it regression?
Not really, this environment variable was never set, but when Edge matches Edgedriver that's fine
Expected behavior
The version of EdgeDriver being used should be set so wdio doesn't try to install a different version.
Actual behavior
The version isn't set so wdio tries to install a different version and if that version is missing jobs may fail.
Repro steps
The text was updated successfully, but these errors were encountered: