-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync-labels should not remove an unspecified label #741
Comments
Hello @OJFord |
This feature would be a neat addition! If there's a way to differentiate manually added labels from auto-added labels by the labeler, that would be great. With |
Description:
I think that even with
sync-labels: true
, a label which is not defined inlabeler.yml
at all should not be removed.Justification:
Some labels might be applied by other means, such as non-labeler workflows marking a PR as 'deployed' for example, which have no file or branch based (or any static/declarative) way of describing when they should exist.
If a label is not even defined according to paths etc., then it should not be removed by labeler - we should assume it has some other source.
If people want labeler to be an absolute source of truth for allowed labels, then an
ignore
key or similar would do - i.e. to define a list of allowed labels which aren't synchronised.Are you willing to submit a PR?
Willing but not that familiar.
The text was updated successfully, but these errors were encountered: