-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding label and logging when paths aren't matched #664
Labels
feature request
New feature or request to improve the current logic
Comments
vvolkgang
added
feature request
New feature or request to improve the current logic
needs triage
labels
Aug 30, 2023
Hello @vvolkgang! |
@MaksimZhukov saw it but scrubbed it off as a logging improvement in general. I can definitely see how both overlap, although the focus here is the label. |
this would be a great feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description:
Handle paths that weren't matched by adding a label and logging (and commenting?) the list of missed paths, so the labeler file can be easily updated.
Justification:
I need all my paths to be labeled or ignored and with ongoing development it will be hard to maintain unless we have systems in place raising visibility of missing paths. #79 doesn't solve this, ideally this would happen for all PRs regardless of the file status.
Are you willing to submit a PR?
Yes, but, TS isn't my tool of trade and when I looked into v4.0.3, it seemed to require inverting the whole process, figured someone who knew the codebase better could come up with a less invasive solution. I've yet to look again since then and I'm not sure if it would be easier with the V5 changes.
The text was updated successfully, but these errors were encountered: