Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python bindings? #4

Open
Robinlovelace opened this issue Apr 6, 2023 · 4 comments
Open

Python bindings? #4

Robinlovelace opened this issue Apr 6, 2023 · 4 comments

Comments

@Robinlovelace
Copy link
Contributor

Good time for me to have a play with this, or too early days in terms of variable API?

@dabreegster
Copy link
Contributor

You could start trying out pyo3 if you want. Would it be easier if I merged the current PR and left all the outstanding tasks as followup? It's in some halfway state right now and gives incorrect results, but the basic CLI is set up at least.

And what's the plan on bindings? The simple answer is we ship a binary and call through the CLI, but that's clunkier installation-wise?

@Robinlovelace
Copy link
Contributor Author

Would it be easier if I merged the current PR and left all the outstanding tasks as followup?

👍 for sure. Good fresh thing to have a play with. Probably best use of my time: write tests!

@Robinlovelace
Copy link
Contributor Author

In terms of how to do bindings well, https://github.com/pola-rs/polars is the best example I know of.

@dabreegster
Copy link
Contributor

Agreed, tests would be helpful! The unit test framework so far is not wired up to check aggregated properties yet, but I could do that next week. In the meantime, just input and expected output GeoJSON files. They could come from the R implementation or anywhere. And if you open https://github.com/actenglabs/overline/blob/master/rust/viewer.html in Firefox (as a local file, not through github), you can visualize an output geojson file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants