You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now we have a few tests for getCss() that are a dumping ground for every unique type of class (hex values, hex + alpha, customs, child selectors, customs, etc). It'd be better if we could break this up into one test per class type, so we can be more explicit about having proper coverage for all syntax we support.
The text was updated successfully, but these errors were encountered:
Currently the getCss method is more than 200 LoC, it is hader to test one huge method that several small ones. What you guys think about simplifying this by create a class that does just css parsing:
@3den That's outside the scope of this issue - here, we're only really interested in ensuring that we have tests for each type of syntax we support. Whether we're testing getCss() or findClassNames() or some other class is really a different issue. I'd suggest opening a new issue to start a discussion on your idea of breaking up getCss()
Right now we have a few tests for
getCss()
that are a dumping ground for every unique type of class (hex values, hex + alpha, customs, child selectors, customs, etc). It'd be better if we could break this up into one test per class type, so we can be more explicit about having proper coverage for all syntax we support.The text was updated successfully, but these errors were encountered: