From aaed6fae2b77546f613b661792e4d4f9148f153b Mon Sep 17 00:00:00 2001 From: Chris Maree Date: Thu, 2 Jan 2025 12:47:19 +0100 Subject: [PATCH 1/2] WIP Signed-off-by: Chris Maree --- contracts/SpokePool.sol | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contracts/SpokePool.sol b/contracts/SpokePool.sol index c8cc1c05a..49fdab53b 100644 --- a/contracts/SpokePool.sol +++ b/contracts/SpokePool.sol @@ -613,7 +613,7 @@ abstract contract SpokePool is } /** - * @notice An overloaded version of `unsafeDepositV3` that accepts `address` types for backward compatibility. * + * @notice An overloaded version of `unsafeDepositV3` that accepts `address` types for backward compatibility. * @dev This version mirrors the original `unsafeDepositV3` function, but uses `address` types for `depositor`, `recipient`, * `inputToken`, `outputToken`, and `exclusiveRelayer` for compatibility with contracts using the `address` type. * @@ -1294,7 +1294,7 @@ abstract contract SpokePool is /** * @notice Returns the deposit ID for an unsafe deposit. This function is used to compute the deposit ID * in unsafeDepositV3 and is provided as a convenience. - * @dev msgSenderand depositor are both used as inputs to allow passthrough depositors to create unique + * @dev msg Sender and depositor are both used as inputs to allow passthrough depositors to create unique * deposit hash spaces for unique depositors. * @param msgSender The caller of the transaction used as input to produce the deposit ID. * @param depositor The depositor address used as input to produce the deposit ID. @@ -1499,7 +1499,7 @@ abstract contract SpokePool is bool success = _noRevertTransfer(l2TokenAddress, refundAddresses[i], refundAmounts[i]); // If the transfer failed then track a deferred transfer for the relayer. Given this function would - // have revered if there was insufficient balance, this will only happen if the transfer call + // have reverted if there was insufficient balance, this will only happen if the transfer call // reverts. This will only occur if the underlying transfer method on the l2Token reverts due to // recipient blacklisting or other related modifications to the l2Token.transfer method. if (!success) { From 4f71cc300ae2bfa69076749f28d67b2e80d61781 Mon Sep 17 00:00:00 2001 From: Matt Rice Date: Sun, 5 Jan 2025 22:05:50 -0500 Subject: [PATCH 2/2] Update contracts/SpokePool.sol --- contracts/SpokePool.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contracts/SpokePool.sol b/contracts/SpokePool.sol index 49fdab53b..89b742ecb 100644 --- a/contracts/SpokePool.sol +++ b/contracts/SpokePool.sol @@ -1294,7 +1294,7 @@ abstract contract SpokePool is /** * @notice Returns the deposit ID for an unsafe deposit. This function is used to compute the deposit ID * in unsafeDepositV3 and is provided as a convenience. - * @dev msg Sender and depositor are both used as inputs to allow passthrough depositors to create unique + * @dev msgSender and depositor are both used as inputs to allow passthrough depositors to create unique * deposit hash spaces for unique depositors. * @param msgSender The caller of the transaction used as input to produce the deposit ID. * @param depositor The depositor address used as input to produce the deposit ID.