Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better filtering options for exporting traces #63

Open
drmorr0 opened this issue Nov 15, 2023 · 0 comments
Open

Better filtering options for exporting traces #63

drmorr0 opened this issue Nov 15, 2023 · 0 comments
Labels
api Changes or improvements to the API or CRDs cli Issues with the skctl CLI sk-tracer Issues with the Kubernetes tracer

Comments

@drmorr0
Copy link
Contributor

drmorr0 commented Nov 15, 2023

Description

Please describe the planned improvement in enough detail that someone who is not you could start working on it. Code hints, acceptance criteria, etc., are all encouraged.

Currently, when exporting a trace, you can filter in one of three ways:

  1. Exclude particular namespaces
  2. Exclude particular label selectors
  3. Exclude DaemonSets

This doesn't really provide the level of flexibility that we want. We should really have some sort of allow/deny rules for namespaces and label selectors, and excluding daemonsets just doesn't even make sense anymore (originally when we were just tracking pods, it made sense because we didn't want simulated copies of the daemonset objects running on the simulated nodes).

I think this requires a bit of thought before writing code. Can we include in this issue a proposal for the various filtering mechanisms that we want? E.g., allow by default vs deny by default, are namespaces and label selectors enough granularity, what happens if we "deny a namespace but include a label selector in that namespace", etc. I think there is some prior art we can look at for guidance here, e.g., how does iptables do this?

See also #68

When making any changes to the tracer API, please read Making API changes.

@drmorr0 drmorr0 added cli Issues with the skctl CLI sk-tracer Issues with the Kubernetes tracer api Changes or improvements to the API or CRDs labels Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Changes or improvements to the API or CRDs cli Issues with the skctl CLI sk-tracer Issues with the Kubernetes tracer
Projects
None yet
Development

No branches or pull requests

1 participant