Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logging best practices #37

Open
aliddell opened this issue Jan 9, 2023 · 1 comment
Open

Use logging best practices #37

aliddell opened this issue Jan 9, 2023 · 1 comment
Assignees
@aliddell
Labels
enhancement New feature or request

Comments

@aliddell
Copy link
Member

aliddell commented Jan 9, 2023 •
edited by nclack
Loading

Use a named logger

cpx-python currently uses the default Python logger, which can potentially be reset and / or reconfigured by other libraries working alongside cpx-python. We should use a named logger to minimize the chance of this happening.

avoid fstrings

For performance. f strings are evaluated at the call site instead of inside.
@aliddell aliddell added the bug Something isn't working label Jan 9, 2023
@aliddell aliddell self-assigned this Jan 9, 2023
@nclack
Copy link
Member

nclack commented Feb 1, 2023

this is such a good idea

@aliddell aliddell transferred this issue from another repository Jun 20, 2023
@aliddell aliddell added enhancement New feature or request and removed bug Something isn't working labels Jun 20, 2023
@Poofjunior Poofjunior mentioned this issue Aug 16, 2023
Closed
@nclack nclack changed the title Use a named logger Use logging best practices Aug 21, 2023
@nclack nclack mentioned this issue Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aliddell aliddell

Labels
enhancement New feature or request
Projects
Image Acquisition Team Board
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nclack @aliddell