Update submodules and test job #303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quire-common. Update test target. Remove automerge job.
aliddell
commented
Aug 1, 2024
Comment on lines
+65
to
98
|
|
||
| # download the acquire-driver-zarr shared library to the tests directory | ||
| include(FetchContent) | ||
|
|
||
| set(ZARR_RELEASE_URL "https://github.com/acquire-project/acquire-driver-zarr/releases/download") | ||
| set(ZARR_VERSION "0.1.12") | ||
|
|
||
| if (WIN32) | ||
| set(ZARR_DRIVER_SUFFIX "win64") | ||
| elseif (APPLE) | ||
| set(ZARR_DRIVER_SUFFIX "Darwin") | ||
| elseif (UNIX) | ||
| set(ZARR_DRIVER_SUFFIX "Linux") | ||
| endif () | ||
|
|
||
| FetchContent_Declare( | ||
| acquire_driver_zarr | ||
| URL "${ZARR_RELEASE_URL}/v${ZARR_VERSION}/acquire-driver-zarr-v${ZARR_VERSION}-${ZARR_DRIVER_SUFFIX}.zip" | ||
| DOWNLOAD_EXTRACT_TIMESTAMP TRUE | ||
| ) | ||
|
|
||
| FetchContent_MakeAvailable(acquire_driver_zarr) | ||
| set(ZARR_DRIVER_PATH ${acquire_driver_zarr_SOURCE_DIR}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}acquire-driver-zarr${CMAKE_SHARED_LIBRARY_SUFFIX}) | ||
|
|
||
| add_custom_target(copy_zarr_driver | ||
| COMMAND ${CMAKE_COMMAND} -E copy | ||
| ${ZARR_DRIVER_PATH} | ||
| $<TARGET_FILE_DIR:${project}-${onename}> | ||
| DEPENDS ${ZARR_DRIVER_PATH} | ||
| COMMENT "Copying acquire-driver-zarr to $<TARGET_FILE_DIR:${project}-${onename}>" | ||
| ) | ||
|
|
||
| add_dependencies(${tgt} copy_zarr_driver) | ||
| endif() |
There was a problem hiding this comment.
I'm of two minds here. We have tests that use the Zarr driver, and we can keep doing that, or we can just use trash storage instead. What do you think @nclack?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the acquire-driver-zarr submodule, using FetchContent to download and extract driver instead. It also updates acquire-common to the latest main. Finally, it triggers tests on
pull_requestrather thanpull_request_targetand removes the automerge job.