From d9fb773c8270680a98cfa26af386823b7e3fdaf0 Mon Sep 17 00:00:00 2001
From: Alan Liddell <aliddell@chanzuckerberg.com>
Date: Fri, 5 Jan 2024 14:12:00 -0500
Subject: [PATCH 1/3] wip

---
 .github/workflows/release.yml | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 92653a6..2fa4042 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -5,6 +5,9 @@ on:
     tags:
       - "v*.*.*"
       - "nightly"
+  pull_request:
+    branches:
+      - main # TODO (aliddell): remove when we understand what's going on
 env:
   BUILD_TYPE: Release
 
@@ -173,10 +176,8 @@ jobs:
   release:
     name: Release
     runs-on: ubuntu-latest
-    needs: # don't release if the tests are failing
-      - test-acquire-core-libs
-      - test-acquire-video-runtime
-      - test-acquire-driver-common
+    needs:
+      - build
     permissions: write-all
     steps:
       - uses: actions/checkout@v3

From 107dd459bc1c1dc8327209687703b78db75ff149 Mon Sep 17 00:00:00 2001
From: Alan Liddell <aliddell@chanzuckerberg.com>
Date: Fri, 5 Jan 2024 14:13:24 -0500
Subject: [PATCH 2/3] wip

---
 .github/workflows/release.yml | 42 +++++++++++++++++++----------------
 1 file changed, 23 insertions(+), 19 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 2fa4042..083f6ed 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -187,22 +187,26 @@ jobs:
         with:
           path: ${{ github.workspace }}/artifacts
 
-      - name: Tagged release
-        if: ${{ github.ref_name != 'nightly' }}
-        uses: marvinpinto/action-automatic-releases@latest
-        with:
-          repo_token: ${{ github.token }}
-          prerelease: false
-          files: |
-            ${{steps.download.outputs.download-path}}/*/*.zip
-
-      - name: Nightly release
-        if: ${{ github.ref_name == 'nightly' }}
-        uses: marvinpinto/action-automatic-releases@latest
-        with:
-          repo_token: ${{ secrets.PAT }}
-          automatic_release_tag: "nightly"
-          prerelease: true
-          title: "Nightly Release"
-          files: |
-            ${{steps.download.outputs.download-path}}/*/*.zip
+      - name: find out what's in the artifacts folder
+        run: ls ${{ github.workspace }}/artifacts
+
+
+#      - name: Tagged release
+#        if: ${{ github.ref_name != 'nightly' }}
+#        uses: marvinpinto/action-automatic-releases@latest
+#        with:
+#          repo_token: ${{ github.token }}
+#          prerelease: false
+#          files: |
+#            ${{steps.download.outputs.download-path}}/*/*.zip
+#
+#      - name: Nightly release
+#        if: ${{ github.ref_name == 'nightly' }}
+#        uses: marvinpinto/action-automatic-releases@latest
+#        with:
+#          repo_token: ${{ secrets.PAT }}
+#          automatic_release_tag: "nightly"
+#          prerelease: true
+#          title: "Nightly Release"
+#          files: |
+#            ${{steps.download.outputs.download-path}}/*/*.zip

From ccf1d198fde5a4c2607003ca1b67f9b641fa8da1 Mon Sep 17 00:00:00 2001
From: Alan Liddell <aliddell@chanzuckerberg.com>
Date: Fri, 5 Jan 2024 14:21:03 -0500
Subject: [PATCH 3/3] The restoration of all things.

---
 .github/workflows/release.yml | 46 +++++++++++++++--------------------
 1 file changed, 20 insertions(+), 26 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 083f6ed..1ba0ab7 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -5,9 +5,7 @@ on:
     tags:
       - "v*.*.*"
       - "nightly"
-  pull_request:
-    branches:
-      - main # TODO (aliddell): remove when we understand what's going on
+
 env:
   BUILD_TYPE: Release
 
@@ -187,26 +185,22 @@ jobs:
         with:
           path: ${{ github.workspace }}/artifacts
 
-      - name: find out what's in the artifacts folder
-        run: ls ${{ github.workspace }}/artifacts
-
-
-#      - name: Tagged release
-#        if: ${{ github.ref_name != 'nightly' }}
-#        uses: marvinpinto/action-automatic-releases@latest
-#        with:
-#          repo_token: ${{ github.token }}
-#          prerelease: false
-#          files: |
-#            ${{steps.download.outputs.download-path}}/*/*.zip
-#
-#      - name: Nightly release
-#        if: ${{ github.ref_name == 'nightly' }}
-#        uses: marvinpinto/action-automatic-releases@latest
-#        with:
-#          repo_token: ${{ secrets.PAT }}
-#          automatic_release_tag: "nightly"
-#          prerelease: true
-#          title: "Nightly Release"
-#          files: |
-#            ${{steps.download.outputs.download-path}}/*/*.zip
+      - name: Tagged release
+        if: ${{ github.ref_name != 'nightly' }}
+        uses: marvinpinto/action-automatic-releases@latest
+        with:
+          repo_token: ${{ github.token }}
+          prerelease: false
+          files: |
+            ${{steps.download.outputs.download-path}}/*/*.zip
+
+      - name: Nightly release
+        if: ${{ github.ref_name == 'nightly' }}
+        uses: marvinpinto/action-automatic-releases@latest
+        with:
+          repo_token: ${{ secrets.PAT }}
+          automatic_release_tag: "nightly"
+          prerelease: true
+          title: "Nightly Release"
+          files: |
+            ${{steps.download.outputs.download-path}}/*/*.zip