Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider camera properties trigger metadata struct #29

Open
andy-sweet opened this issue Sep 26, 2023 · 0 comments
Open

Reconsider camera properties trigger metadata struct #29

andy-sweet opened this issue Sep 26, 2023 · 0 comments

Comments

@andy-sweet
Copy link
Contributor

In acquire-project/acquire-core-libs#18, there was some discussion about the inability to express the trigger_wait output line/trigger in the properties metadata.

The CameraPropertiesTriggerMetadata struct captures three triggers (frame_start, acquisition_start, exposure) and allows to express which input/output lines these can be enabled on using a bit mask over the 8 possible lines.

One problem with this struct is that the trigger_wait output trigger is not captured by this struct, so its capabilities/metadata cannot be expressed. That can be easily fixed by adding a trigger_wait member to the CameraPropertiesTriggerMetadata struct.

But we may want to consider wider changes to this struct, so that it more closely mirrors the corresponding CameraProperties struct. For example, we could define a CameraPropertiesTriggerMetadata::input::acquisition_start bit-mask instead of CameraPropertiesTriggerMetadata::acquisition_start::input one.

@aliddell aliddell transferred this issue from acquire-project/acquire-core-libs Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant