Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logs write full source paths #26

Open
nclack opened this issue May 8, 2023 · 0 comments
Open

logs write full source paths #26

nclack opened this issue May 8, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@nclack
Copy link
Member

nclack commented May 8, 2023

Log messages look like this right now:

DEBUG    acquire.runtime:runtime.rs:42 C:\acquire-python\acquire-driver-zarr\src\acquire-core-libs\src\acquire-device-hal\device\hal\device.manager.cpp:223 - `anonymous-namespace'::DeviceManagerV0::select(): Selecting (3,0) for Camera "VIEWORKS VP-151MX-M6H0 MP151BBX050"
DEBUG    acquire.runtime:runtime.rs:42 C:\acquire-python\acquire-driver-zarr\src\acquire-core-libs\src\acquire-device-hal\device\hal\device.manager.cpp:223 - `anonymous-namespace'::DeviceManagerV0::select(): Selecting (0,5) for Storage "Trash"
DEBUG    acquire.runtime:runtime.rs:42 C:\acquire-python\acquire-driver-zarr\src\acquire-core-libs\src\acquire-device-hal\device\hal\device.manager.cpp:223 - `anonymous-namespace'::DeviceManagerV0::select(): Selecting (0,5) for Storage "Trash"
DEBUG    acquire.runtime:runtime.rs:42 C:\acquire-python\acquire-driver-zarr\src\acquire-core-libs\src\acquire-device-hal\device\hal\device.manager.cpp:223 - `anonymous-namespace'::DeviceManagerV0::select(): Selecting (0,5) for Storage "Trash"
DEBUG    acquire.runtime:runtime.rs:42 C:\acquire-python\acquire-driver-zarr\src\acquire-core-libs\src\acquire-device-hal\device\hal\device.manager.cpp:223 - `anonymous-namespace'::DeviceManagerV0::select(): Selecting (0,5) for Storage "Trash"
DEBUG    acquire.runtime:runtime.rs:42 C:\acquire-python\acquire-driver-zarr\src\acquire-core-libs\src\acquire-device-hal\device\hal\device.manager.cpp:223 - `anonymous-namespace'::DeviceManagerV0::select(): Selecting (0,5) for Storage "Trash"

It would be nice if there were some facility for increasing the signal-to-noise in the source-path part of the log line. Also, we probably don't want to expose full paths of build machines in shipped packages.

For example:

DEBUG    acquire.runtime:runtime.rs:42 acquire-device-hal\device\hal\device.manager.cpp:223 - `anonymous-namespace'::DeviceManagerV0::select(): Selecting (0,5) for Storage "Trash"

is shorter and communicates mostly the same info.

@aliddell aliddell added the bug Something isn't working label Jul 13, 2023
@aliddell aliddell transferred this issue from acquire-project/acquire-core-libs Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

2 participants