Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device_manager_validate_identifier #25

Open
nclack opened this issue May 4, 2023 · 0 comments
Open

device_manager_validate_identifier #25

nclack opened this issue May 4, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@nclack
Copy link
Member

nclack commented May 4, 2023

In acquire-project/acquire-core-libs#6, I deleted a block of code that was doing identifier validation (in storage_validate).

The validation part is a good idea, but we were using device_manager_select to do it, resulting in some undesired log messages. Really it would be better to have a dedicated validation function and use that more broadly during configuration for validating device selection.

It should basically go through calling describe and confirm the type looks right.

@aliddell aliddell added the enhancement New feature or request label Jul 13, 2023
@aliddell aliddell transferred this issue from acquire-project/acquire-core-libs Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants