Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add precommit to github actions #14

Open
4 tasks
nclack opened this issue Jan 10, 2023 · 0 comments
Open
4 tasks

add precommit to github actions #14

nclack opened this issue Jan 10, 2023 · 0 comments
Assignees
@aliddell

Comments

@nclack
Copy link
Member

nclack commented Jan 10, 2023

In acquire-project/cpx#76, I added some pre-commit checks that basically outline the linters we should run regularly. cppcheck was especially useful. Also, the PR checks are the right place to do apply these kinds of controls - pre-commit is just a helpful tool.

Candidate checks are:

  • clang-tidy
  • cppcheck
  • clang-format
  • run tests w valgrind
@aliddell aliddell transferred this issue from another repository Jun 20, 2023
@aliddell aliddell changed the title add linting to github actions add precommit to github actions Jul 21, 2023
@aliddell aliddell transferred this issue from acquire-project/acquire-video-runtime Jan 5, 2024
@aliddell aliddell closed this as completed Apr 2, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Complete in Image Acquisition Team Board Apr 2, 2024
@aliddell aliddell reopened this Apr 2, 2024
@github-project-automation github-project-automation bot moved this from Complete to In Progress in Image Acquisition Team Board Apr 2, 2024
@aliddell aliddell moved this from In Progress to Priority Backlog in Image Acquisition Team Board Apr 2, 2024
@aliddell aliddell self-assigned this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aliddell aliddell

Labels
None yet
Projects
Image Acquisition Team Board
Status: Priority Backlog
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

14-add-precommit-to-github-actions aliddell/acquire-common
2 participants
@nclack @aliddell