Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Resolved offerings not generated for containers when there are containers with same name as a sidecar container or multiple containers with same sidecar name #2469

Open
sangee2004 opened this issue Jan 31, 2024 · 0 comments
Labels
kind/bug Something isn't working
Milestone

Comments

@sangee2004
Copy link
Contributor

acorn version - v0.10.1-rc1-18-g523ede04+523ede04
Steps to reproduce the problem:

  1. Deploy app with following Acornfile where 2 containers have the side cars with same name
containers: {
	nginx: {
		sidecars: ubuntu:
		{
			image: "ubuntu:latest"
			cmd: ["bash", "-c", "sleep infinity"]
		}
		image: "nginx:latest"
		ports: "80/http"
	}
	nginx1: {
		sidecars: ubuntu:
		{
			image: "ubuntu:latest"
			cmd: ["bash", "-c", "sleep infinity"]
		}
		image: "nginx:latest"
		ports: "80/http"
	}
}

Once app is deployed, notice that resolvedOfferings is reported only for 1 of the sidecars.

               "resolvedOfferings": {
                    "containers": {
                        "": {
                            "class": "free",
                            "memory": 536870912,
                            "cpuScaler": 0.25
                        },
                        "nginx": {
                            "class": "free",
                            "memory": 536870912,
                            "cpuScaler": 0.25
                        },
                        "nginx1": {
                            "class": "free",
                            "memory": 536870912,
                            "cpuScaler": 0.25
                        },
                        "ubuntu": {
                            "class": "free",
                            "memory": 536870912,
                            "cpuScaler": 0.25
                        }
                    },
  1. Deploy app with following Acornfile where there is a container with same name as a sidecar container
containers: nginx: {
	sidecars: ubuntu:
	{
		image: "ubuntu:latest"
		cmd: ["bash", "-c", "sleep infinity"]
	}
	image: "nginx:latest"
	ports: "80/http"
}

containers: ubuntu:
{
	image: "ubuntu:latest"
	cmd: ["bash", "-c", "sleep infinity"]
}

Once app is deployed, notice that resolvedOfferings is reported only for 2 containers:

              "resolvedOfferings": {
                    "containers": {
                        "": {
                            "class": "free",
                            "memory": 536870912,
                            "cpuScaler": 0.25
                        },
                        "nginx": {
                            "class": "free",
                            "memory": 536870912,
                            "cpuScaler": 0.25
                        },
                        "ubuntu": {
                            "class": "free",
                            "memory": 536870912,
                            "cpuScaler": 0.25
                        }
                    },

Expected Behavior:

  1. In both cases, we expect resolvedOfferings to be reported for all containers.
@sangee2004 sangee2004 added kind/bug Something isn't working help wanted Extra attention is needed labels Jan 31, 2024
@sangee2004 sangee2004 added this to the Backlog milestone Jan 31, 2024
@sangee2004 sangee2004 changed the title Resolved offerings not generated when there are containers with same name as a sidecar container or multiple container with same side cars Resolved offerings not generated for containers when there are containers with same name as a sidecar container or multiple container with same side cars Jan 31, 2024
@sangee2004 sangee2004 changed the title Resolved offerings not generated for containers when there are containers with same name as a sidecar container or multiple container with same side cars Resolved offerings not generated for containers when there are containers with same name as a sidecar container or multiple containers with same side cars Jan 31, 2024
@sangee2004 sangee2004 changed the title Resolved offerings not generated for containers when there are containers with same name as a sidecar container or multiple containers with same side cars Resolved offerings not generated for containers when there are containers with same name as a sidecar container or multiple containers with same sidecar name Jan 31, 2024
@cjellick cjellick removed the help wanted Extra attention is needed label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants