Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual and Style Fixes #136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

angelatsai1214
Copy link
Contributor

Finish issue #114

image
  • made the Login button bolder so looks about the same size as the rest of the navbar text
  • added gradient bar to non-main-pages
  • made the cards in projects page all the same height, if description overflows, then the card is scrollable
  • as well as address the changes needed from the issue

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the responsiveness of this. Might be better to follow devpost's style of limiting the title and description text instead?
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the footer has the gradient bar added, why is the gradient also added directly in EventsPage/index.tsx?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MainFooter component was not used for EventsPage which I think is because the Events Page has some customized content they are displaying at the footer, while all the rest of the pages use the same content for the footer, do you want me to change so that the MainFooter would take in parameter for the content of the footer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm can we move the events page footer info to a different format (similar to the homepage) and add the MainFooter? that way we can standardize the footer component across the site
image

src/pages/MainPage/index.tsx Show resolved Hide resolved
@sprestrelski sprestrelski linked an issue Aug 1, 2024 that may be closed by this pull request
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual and style fixes
2 participants