Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeriodO #7

Open
zoometh opened this issue Oct 9, 2023 · 8 comments
Open

PeriodO #7

zoometh opened this issue Oct 9, 2023 · 8 comments
Assignees

Comments

@yourvick
Copy link
Contributor

  • locator is just for page/figure numbers on a reference, so we can leave this blank if we are referencing the database
  • spatialCoverageDescription and label need rejigging - for example spatialCoverageDescription will be Levant/Mesopotamia/Arabia while label and id within spatialCoverage will have each individual country in the wikidata_period.tsv list so Lebanon, Syria, Jordan etc etc this means there will be multiple spatialCoverage records (usually) with therefore multiple label and id subrecords
  • I don't think, if we have don't have anything to say, that we need to use note and editorialNote, both are used for lots of different things in the PeriodO canon dataset, or often, not at all
  • I think the DB website link is fine for url

@yourvick
Copy link
Contributor

Like so - here column one is the spatialCoverageDescription while column 3 and 4 will be label and id subrecords respectively.
image

@zoometh
Copy link
Member Author

zoometh commented Oct 10, 2023

@yourvick
Copy link
Contributor

I think it would be a real shame to lose the spatial information for all those periods - as around half of periods would be composite? Better to find a way of adding multiple entries to the json I reckon?

@yourvick
Copy link
Contributor

What if we edited the json template to have the maximum number of nested spatialcoverages etc possible label1, id1, label2, id1 etc etc and then just regexed the final json file to remove the numbers and any blank spatialCoverage records?

@zoometh
Copy link
Member Author

zoometh commented Oct 11, 2023

Yes. For example: Mesopotamia here with this spatial extent:

"spatialCoverage": [
{
"id": "http://www.wikidata.org/entity/Q794",
"label": "Iran"
},
{
"id": "http://www.wikidata.org/entity/Q796",
"label": "Iraq"
},
{
"id": "http://www.wikidata.org/entity/Q858",
"label": "Syria"
},
{
"id": "http://www.wikidata.org/entity/Q43",
"label": "Turkey"
}
],

@zoometh zoometh changed the title PeriodO questions PeriodO Oct 12, 2023
@zoometh
Copy link
Member Author

zoometh commented Oct 12, 2023

I have noticed, and corrected these errors in the EAMENA period labels. To be compliant with EAMENA overall layout, cultures (eg. Ghaznavid, Timurid, Mamluk, etc.) should not be in parenthesis. Only the geographical region has to be in parenthesis. I've changed the parenthesis to brackets for:

  • Dynastic Egypt renamed Dynastic Egypt (Egypt)
  • Islamic, Middle (Ghaznavid/Seljuq/Khwarazmshah) (Iran) renamed Islamic, Middle [Ghaznavid/Seljuq/Khwarazmshah] (Iran)
  • Islamic, Late (Timurid/Safavid/Qajar) (Iran) renamed Islamic, Late [Timurid/Safavid/Qajar]
  • Islamic, Early (Tahirid/Saffarid/Samanid/Buyids) (Iran) renamed Islamic, Early [Tahirid/Saffarid/Samanid/Buyids] (Iran)
  • Islamic, Middle (Mongol/Ilkhanid/Muzaffarid/Jalayrid) renamed ...
  • Islamic, Early (Ummayad/Abbasid) ...
  • Islamic, Late (Mamluk/Rasulid) (Levant/Arabia) ...
  • Islamic, Late (Ottoman) (Levant/Arabia)
  • Islamic, Middle (Fatimid/Ayyubid/Crusader) (Levant/Arabia)
  • Islamic, Early (Umayyad/Abbasid/Fatimid) (Levant/Arabia)
  • Islamic, Early (Umayyad/Abbasid) (North Africa)
  • Islamic, Middle (Fatimid/Zirid/Hammadid/Almoravid/Almohad) (North Africa)
  • Islamic, Late (Ottoman/Saadi/Wattasid/Alaouite/Colonial) (North Africa)
  • Islamic, Late (Ayyubid/Hafsid/Marinid/Zayyanid/Mamluk) (North Africa)
  • Islamic, Late (Ottoman) (Iraq)
  • Islamic, Early (Early Caliphate/Umayyad)
  • Islamic, Middle (Abbasid)
  • Islamic, Late (Post-Abbasid)

@zoometh
Copy link
Member Author

zoometh commented Oct 19, 2023

In the same manner, these labels need to be changes in rdm-bu-period.check.xlsx. The results is:

  • Islamic, Early [Umayyad/Abbasid/Fatimid] (Levant/Arabia)
  • Islamic, Middle [Fatimid/Ayyubid] (Levant/Arabia)
  • Islamic, Late [Mamluk/Rasulid] (Levant/Arabia)
  • Islamic, Late [Ottoman] (Levant/Arabia)
  • Islamic, Early [Early Caliphate/Umayyad] (Iraq)
  • Islamic, Middle [Abbasid] (Iraq)
  • Islamic, Late [Post-Abbasid] (Iraq)
  • Islamic, Late [Ottoman) (Iraq)
  • Islamic, Early [Ummayad/Abbasid] (Iran)
  • Islamic, Early [Tahirid/Saffarid/Samanid/Buyids] (Iran)
  • Islamic, Middle [Ghaznavid/Seljuq/Khwarazmshah] (Iran)
  • Islamic, Middle [Mongol/Ilkhanid/Muzaffarid/Jalayrid] (Iran)
  • Islamic, Late [Timurid/Safavid/Qajar] (Iran)
  • Islamic, Early [Umayyad/Abbasid] (North Africa)
  • Islamic, Middle [Fatimid/Zirid/Hammadid/Almoravid/Almohad] (North Africa)
  • Islamic, Late [Ayyubid/Hafsid/Marinid/Zayyanid/Mamluk] (North Africa)
  • Islamic, Late [Ottoman/Saadi/Wattasid/Alaouite/Colonial] (North Africa)
  • ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants