Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harmonize document type markup #102

Open
dasch124 opened this issue Dec 2, 2024 · 2 comments
Open

harmonize document type markup #102

dasch124 opened this issue Dec 2, 2024 · 2 comments

Comments

@dasch124
Copy link
Member

dasch124 commented Dec 2, 2024

Currently, the mark-up indicating the type of a document varies from type to type.
In the "old" VICAV headers, we don't have any indicator at all, or - like in TUNOCENT - use this structure (invalid BTW):

<taxonomy>
    <category xml:id="featurelist">
       <catDesc>linguistic feature list</catDesc>
    </category>
</taxonomy>

I'd like to harmonize this to the format we use in the TUNOCENT corpus documents, i.e.

<textClass>
    <catRef target="corpus:datatypes.vicav.fl"/>
</textClass>

Would changing this in the data break things in the back-end?

@MauPalantir
Copy link
Contributor

@dasch124 TUNOCENT only uses these categories at one place on BaseX side. I pushed a PR that modifies that part of the code and will push the correponding changes to vicav-vue repo as well.
The other place, the old logic for generating dat lists are not used in vicav vue any more.

However, Wibarab proejct seems to have some custom logic in the vicav basex backend which is tied to this structure, so I think we should coordinate with whoever is responsible for the wibarab data and wibarab-specific VICAV features:
https://github.com/acdh-oeaw/vicav-app/blob/master/vicav.xqm#L191
https://github.com/acdh-oeaw/vicav-app/blob/master/vicav.xqm#L218

@kisram
Copy link
Contributor

kisram commented Jan 15, 2025

@dasch124 TUNOCENT only uses these categories at one place on BaseX side. I pushed a PR that modifies that part of the code and will push the correponding changes to vicav-vue repo as well. The other place, the old logic for generating dat lists are not used in vicav vue any more.

However, Wibarab proejct seems to have some custom logic in the vicav basex backend which is tied to this structure, so I think we should coordinate with whoever is responsible for the wibarab data and wibarab-specific VICAV features: https://github.com/acdh-oeaw/vicav-app/blob/master/vicav.xqm#L191 https://github.com/acdh-oeaw/vicav-app/blob/master/vicav.xqm#L218

That would be me. We're currently working on harmonizing the WIBARAB data structure anyway, if/when we adapt the TUNOCENT format, I'll adjust the query if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants